Fixed image in README.rst #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone have any clue why Travis is not passing? I've verified that the image is readable. |
|
@dherrada looks like adding ~/Dev/circuitpython_libs/Adafruit_CircuitPython_CircuitPlayground/docs:$> git diff
diff --git a/README.rst b/README.rst
index 3b69922..73c3f7e 100644
--- a/README.rst
+++ b/README.rst
@@ -16,7 +16,7 @@ Introduction
This high level library provides objects that represent CircuitPlayground hardware.
-.. image :: /_static/circuitplayground_express.jpg
+.. image :: ../docs/_static/circuitplayground_express.jpg
:target: https://adafruit.com/product/3333
:alt: CircuitPlayground Express
~/Dev/circuitpython_libs/Adafruit_CircuitPython_CircuitPlayground/docs:$> sphinx-build -E -W -b html . _build/html
Running Sphinx v2.0.0
making output directory... done
loading intersphinx inventory from https://docs.python.org/3.4/objects.inv...
loading intersphinx inventory from https://circuitpython.readthedocs.io/en/latest/objects.inv...
loading intersphinx inventory from https://circuitpython.readthedocs.io/projects/neopixel/en/latest/objects.inv...
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 3 source files that are out of date
updating environment: 3 added, 0 changed, 0 removed
reading sources... [100%] index
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] index
generating indices... genindex py-modindex
highlighting module code... [100%] adafruit_circuitplayground.express
writing additional pages... search/home/sommersoft/.local/lib/python3.6/site-packages/sphinx_rtd_theme/search.html:20: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.
{{ super() }}
copying images... [100%] ../docs/_static/circuitplayground_express.jpg
copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.
The HTML pages are in _build/html. |
|
Thanks for the help! |
sommersoft
approved these changes
May 9, 2019
|
@sommersoft So it looks like the only way to get travis to pass is to use ../docs, and the only way to have the image show up is with docs or ./docs |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 25, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.0.6 from 2.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#58 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#55 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#53 from karengineering/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#48 from adafruit/revert-47-add-blinka-to-requirements-txt > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#47 from demophoon/add-blinka-to-requirements-txt Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.1.4 from 1.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#8 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#7 from TG-Techie/patch-2 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_AzureIoT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.