Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Type Annotations #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Add Type Annotations #3

merged 3 commits into from
Aug 27, 2022

Conversation

sokratisvas
Copy link
Contributor

My attempt to fix #2 .

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something got added by accident!

@@ -28,11 +28,18 @@
"""

import time
from tkinter.messagebox import NO # pylint: disable=unused-import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was accidentally commited, it definitely isn't needed 😄

Copy link
Contributor Author

@sokratisvas sokratisvas Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I don't know where that came from. I removed that line.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tekktrik tekktrik merged commit 67be9d7 into adafruit:main Aug 27, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 27, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_GUVX_I2C to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_GUVX_I2C#3 from sokratisvas/add-type-annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.20 from 3.4.19:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#34 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.3.10 from 1.3.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA260#20 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.2.9 from 2.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#32 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.3.9 from 1.3.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#16 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.15 from 1.1.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#13 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.0.12 from 1.0.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#8 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.3 from 1.14.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#80 from tekktrik/bugfix/multiple-networks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants