Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Multidisplay support #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 21, 2022
Merged

Conversation

makermelissa
Copy link
Collaborator

Fixes #74. Fixes #67.

This has been tested on the FeatherWings. I have included examples. Library should function as before with single displays. The main difference is a lot of the hard-coded numbers are now calculated.

@makermelissa makermelissa requested a review from a team June 15, 2022 19:27
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look and saw typing updates, so just looked at those, didn't test. Nice!

@tekktrik tekktrik requested a review from a team June 15, 2022 20:10
@makermelissa
Copy link
Collaborator Author

makermelissa commented Jun 15, 2022

Currently this only supports side by side matrices, but it should be easy enough to update for vertically stacked I think.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved after minor change

@dhalbert dhalbert merged commit 5535baf into adafruit:main Jun 21, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 22, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.0 from 4.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#164 from dannystaple/use-connection-errors

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.5.0 from 4.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#101 from makermelissa/multidisplay-support

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 3.0.0 from 2.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#36 from vladak/celsius

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.10.5 from 1.10.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#14 from tekktrik/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.1.1 from 4.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Logging#32 from tekktrik/doc/fix-doc-and-types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Multiple Display Support for 7-Segment, Alphanumeric, and Matrix Displays 8-digit seven segment display
3 participants