Correct _PDO_RESPONSE_CODES list #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the HUSB238 datasheet the value 010 in the PD_RESPONSE section of the PD_STATUS1 register should be reserved. Updated the _PDO_RESPONSE_CODES list to account for this, so that when the list is accessed using the self.response value the correct response string is returned.
|
closes #4 |
You're welcome! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4
According to the HUSB238 datasheet the value
010in thePD_RESPONSEsection of thePD_STATUS1register should be reserved.Updated the
_PDO_RESPONSE_CODESlist to account for this, so that when the list is accessed using theself.responsevalue the correct response string is returned.