Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Working P1-P6 formats #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 113 commits into from
May 22, 2019
Merged

Working P1-P6 formats #12

merged 113 commits into from
May 22, 2019

Conversation

matt-land
Copy link
Contributor

Opening to see what Travis says

@tannewt
Copy link
Member

tannewt commented May 13, 2019

Thank you! Please ping me when it's ready for review.

@matt-land
Copy link
Contributor Author

Scott,
It's still failing pylint, but I'd like to do review round #1 before I fix those last few things.

@tannewt tannewt self-requested a review May 15, 2019 17:18
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! The only suggestion I have is to update the copyright. I definitely didn't write these files. :-)

@matt-land
Copy link
Contributor Author

I had to rework some things to pass pylint and fix a bug. If this looks good, I'll merge.

@crookedstorm @Riddlerat

@crookedstorm
Copy link
Contributor

@matt-land Looks great! Thank you for cleaning up all our noodling at the end. ❤️

@matt-land matt-land merged commit 74b287c into adafruit:master May 22, 2019
@tannewt tannewt mentioned this pull request May 31, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 1, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.2.1 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#39 from caternuson/iss36

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#5 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#6 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#3 from brentru/patch-return-message

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.9.1 from 0.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#14 from tannewt/move_tests
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#12 from crookedstorm/feature-tests
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#13 from matt-land/bugfix-fix-the-build-sphinx
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#7 from tannewt/use_bitmap_subscr
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#11 from crookedstorm/docs-add-development-guide

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 2.0.0 from 1.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#30 from adafruit/revert-29-master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants