Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CircuitPython 7 no longer allows StopIteration fallback #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2021
Merged

CircuitPython 7 no longer allows StopIteration fallback #55

merged 3 commits into from
Sep 7, 2021

Conversation

deshipu
Copy link
Contributor

@deshipu deshipu commented Sep 2, 2021

Now we have to explicitly catch it.

@deshipu
CircuitPython 7 no longer allows StopIteration fallback
45d8e1a 
Now we have to explicitly catch it.
@deshipu
Fix unrelated failing tests
5e120fd 
No idea how that change got merged in the first place...
@deshipu deshipu force-pushed the master branch 2 times, most recently from b361221 to 19a2be7 Compare September 3, 2021 19:23
@deshipu deshipu requested a review from FoamyGuy September 3, 2021 19:34
FoamyGuy
FoamyGuy approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

I tested gif image loading with

Adafruit CircuitPython 7.0.0-rc.1 on 2021-09-02; Adafruit PyPortal with samd51j20
Board ID:pyportal

Also ran the updated test scripts successfully.

@tannewt tannewt merged commit a26b45c into adafruit:main Sep 7, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 14, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@3dfaf62)
04c10c9 
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.9.1 from 3.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#66 from lesamouraipourpre/rmc
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#59 from lesamouraipourpre/pylint-yaml

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.12.1 from 2.12.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#67 from eliotg/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.15.2 from 1.15.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#55 from deshipu/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deshipu @FoamyGuy @tannewt