Thanks to visit codestin.com
Credit goes to github.com

Skip to content

adding tilegrid_inflator #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Conversation

FoamyGuy
Copy link
Contributor

New helper function for inflating tilegrids, essentially helper code for what is shown on this learn guide page: https://learn.adafruit.com/circuitpython-display-support-using-displayio/multiple-tilegrids

Marking this as Draft for now, because I think it should still get an example added before merging. But I'm open to review / feedback if anyone wants to take a look.

@FoamyGuy
Copy link
Contributor Author

The latest commits add an example using the castle spritesheet from the displayio learn guide. The example produces this TileGrid:
image

@FoamyGuy FoamyGuy marked this pull request as ready for review April 23, 2022 19:07
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions (and kudos) before approving, but nothing that is specifically "requesting changes"!

@@ -12,3 +12,6 @@

.. automodule:: adafruit_imageload.bmp.indexed
:members:

.. automodule:: adafruit_imageload.tilegrid_inflator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always forget to do this, nice!


Load 3x3 spritesheet and inflate it to a larger sized TileGrid

.. literalinclude:: ../examples/imageload_tilegrid_inflator_simpletest.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooo, I haven't seen this directive, I'll have to remember this one.

@dhalbert dhalbert changed the title adding tilegird_inflator adding tilegrid_inflator Apr 26, 2022
@tekktrik tekktrik self-requested a review April 28, 2022 00:08
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @FoamyGuy!

@FoamyGuy FoamyGuy merged commit 7c18538 into adafruit:main Apr 29, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 30, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.16.0 from 1.15.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#58 from FoamyGuy/tilegrid_inflator
  > change discord badge
  > Patch: Replaced discord badge image
  > Update .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants