rainbow commet fix for tail_length > 256 #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Dec 16, 2024
ladyada
approved these changes
Dec 18, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 19, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.5.0 from 3.4.12: > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#80 from dhalbert/faster-I2C Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.10.1 from 2.10.0: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#122 from FoamyGuy/rainbowcommet_256_length_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiz to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Wiz#1 from FoamyGuy/fix_typing_import Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Wiz Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Resolves: #95
Confirmed the reported issue and this fix using tail_length 257. Tested with neopixel featherwing and feather rp2040