mini lint #2
mini lint #2
Conversation
README.rst
Outdated
| @@ -13,7 +13,7 @@ Introduction | |||
| :target: https://travis-ci.org/adafruit/Adafruit_CircuitPython_MPRLS | |||
| :alt: Build Status | |||
|
|
|||
| .. todo:: Describe what the library does. | |||
| CircuitPython library to support VEML6075 UVA & UVB sensor. | |||
There was a problem hiding this comment.
CircuitPython library to support Honeywell MPRLS digital pressure sensors.
adafruit_mprls.py
Outdated
|
|
||
| self._psimax = psi_max | ||
| self._psimin = psi_min | ||
| # That's pretty much it, there's no ID register :( |
There was a problem hiding this comment.
The no ID register is a super bummer. I hesitate to recommend conditionals for the psi_max, since it varies by sensor. And there are too many models to sub-class it out..
I would check that psi_min < psi_max though...accidental argument assignments will throw some interesting math at the user. 😄
|
@sommersoft yay now passing, ready for another look! |
docs/conf.py
Outdated
| @@ -20,7 +20,7 @@ | |||
| # Uncomment the below if you use native CircuitPython modules such as | |||
| # digitalio, micropython and busio. List the modules you use. Without it, the | |||
| # autodoc module docs will fail to generate with a warning. | |||
| # autodoc_mock_imports = ["digitalio", "busio"] | |||
| autodoc_mock_imports = ["digitalio", "busio", "micropython"] | |||
There was a problem hiding this comment.
Apparently this one got lost on my initial review too. busio not needed.
adafruit_mprls.py
Outdated
| self._eoc.direction = Direction.INPUT | ||
|
|
||
| if psi_min >= psi_max: | ||
| raise RuntimeError("Min PSI must be < max!") |
There was a problem hiding this comment.
Nit-noid alert: shouldn't this be a ValueError?
|
amazin' i wrote up a checklist for me so they should be easier going forward |
No description provided.