add addtional RTD info #65

tcfranks · 2023-03-20T01:10:40Z

resolves #56

submitted for initial review and comment

tcfranks · 2023-03-20T01:14:45Z

note: I did not do the base object, since I'm looking for feedback on how far I missed the mark on these three. I anticipate directions to complete the base, if we feel that should be done.....

jposada202020 · 2023-03-20T03:19:57Z

Hello :), thanks for the add I could take a look adn we could work together, there is one thing that needs to be added in order to show the documentation in the __init__ in read the docs. at the moment, the docs are like this

in order to show the changes that you are doing, we need to add the following line in conf.py in the docs directory, in

Adafruit_CircuitPython_PN532/docs/conf.py

Line 41 in 0061f33

autoclass_content = "both"

This would generate the documentation after merging the changes that you are proposing like this:

You could check the effect of building the docs locally. If you have any question please feel free either here or in discord :)

adafruit_pn532/i2c.py

jposada202020

As mentioned :). we could take a look to SPI and UART after

tcfranks · 2023-03-21T18:28:43Z

@jposada202020 you mentioned building the docs locally and reviewing - what process does that? If you can even point to a link I'm willing to dig a bit more.

jposada202020 · 2023-03-21T18:53:41Z

@tcfranks hello:) hello you will need to install sphinx, and sphinx-rtd-theme with a pip command, nothing very complicated
for instructions https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/sharing-our-docs-on-readthedocs
You will change to the docs directory in your clone repo and do the command
sphinx-build -E -W -b html . _build/html and then read the API.html in your preferred browser. It is very nice, and you could see the effects of any changes without the need of the CI in seconds :)

jposada202020

Besides the suggested change, looks good to me. let me know if you want to merge these changes first, or you want to work in the main file too in this PR. Thanks for these changes

adafruit_pn532/spi.py

tcfranks · 2023-03-23T18:54:59Z

@jposada202020 I have a problem running the sphinx-build command. It seems not to see items imported inside the try block. Moved the first two outside just to test (digitalio.DigitalInOut and circuitpython-typing.ReadableBuffer. It then fails because the typing library isn't found. so it appears it's not quite as straightforward as the docs are suggesting. Any ideas?

tcfranks · 2023-03-23T18:59:49Z

error examples (most recent first)
Warning, treated as error:
autodoc: failed to import module 'adafruit_pn532' from module 'adafruit_pn532'; the following exception was raised:
No module named 'circuitpython_typing'

File "C:\Users\Thomas\PycharmProjects\Adafruit_CircuitPython_PN532\adafruit_pn532\adafruit_pn532.py", line 157, in
class PN532:
File "C:\Users\Thomas\PycharmProjects\Adafruit_CircuitPython_PN532\adafruit_pn532\adafruit_pn532.py", line 275, in PN532
params: ReadableBuffer = b"",
NameError: name 'ReadableBuffer' is not defined

File "", line 241, in _call_with_frames_removed
File "C:\Users\Thomas\PycharmProjects\Adafruit_CircuitPython_PN532\adafruit_pn532\adafruit_pn532.py", line 159, in
class PN532:
File "C:\Users\Thomas\PycharmProjects\Adafruit_CircuitPython_PN532\adafruit_pn532\adafruit_pn532.py", line 166, in PN532
irq: Optional[DigitalInOut] = None,
NameError: name 'DigitalInOut' is not defined

jposada202020 · 2023-03-23T19:42:46Z

@tcfranks are you working in a virtual environment? there could be two problems according to my experience:
Update sphinx to 6.X.X. in the library docs directory requirements.txt we request sphinx>=4.0.0

Also as you could see in the requirements.txt you have the following requirements. So you can install them in your virtual environment

Adafruit-Blinka
adafruit-circuitpython-busdevice
adafruit-circuitpython-typing
pyserial
typing-extensions~=4.0

I have reproduced the error that your are having, eliminating typing-extensions from my virtual environment.

(venv) j@j:~/PycharmProjects/Adafruit_CircuitPython_PN532/docs$ sphinx-build -E -W -b html . _build/html
Running Sphinx v6.1.3
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
loading intersphinx inventory from https://docs.circuitpython.org/projects/busdevice/en/latest/objects.inv...
loading intersphinx inventory from https://docs.circuitpython.org/en/latest/objects.inv...
building [mo]: targets for 0 po files that are out of date
writing output... 
building [html]: targets for 3 source files that are out of date
updating environment: [new config] 3 added, 0 changed, 0 removed
reading sources... [100%] index                                                                                            

Warning, treated as error:
autodoc: failed to import module 'adafruit_pn532' from module 'adafruit_pn532'; the following exception was raised:
Traceback (most recent call last):
  File "/home/j/circuitpython projects/venv/lib/python3.10/site-packages/sphinx/ext/autodoc/importer.py", line 60, in import_module
    return importlib.import_module(modname)
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/j/PycharmProjects/Adafruit_CircuitPython_PN532/adafruit_pn532/adafruit_pn532.py", line 159, in <module>
    class PN532:
  File "/home/j/PycharmProjects/Adafruit_CircuitPython_PN532/adafruit_pn532/adafruit_pn532.py", line 166, in PN532
    irq: Optional[DigitalInOut] = None,
NameError: name 'DigitalInOut' is not defined

(venv) j@j:~/PycharmProjects/Adafruit_CircuitPython_PN532/docs$ pip install typing-extensions
Collecting typing-extensions
  Using cached typing_extensions-4.5.0-py3-none-any.whl (27 kB)
Installing collected packages: typing-extensions
Successfully installed typing-extensions-4.5.0
(venv) j@j:~/PycharmProjects/Adafruit_CircuitPython_PN532/docs$ sphinx-build -E -W -b html . _build/html
Running Sphinx v6.1.3
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
loading intersphinx inventory from https://docs.circuitpython.org/projects/busdevice/en/latest/objects.inv...
loading intersphinx inventory from https://docs.circuitpython.org/en/latest/objects.inv...
building [mo]: targets for 0 po files that are out of date
writing output... 
building [html]: targets for 3 source files that are out of date
updating environment: [new config] 3 added, 0 changed, 0 removed
reading sources... [100%] index                                                                                            
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] index                                                                                             
generating indices... genindex py-modindex done
writing additional pages... search done
copying static files... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done
build succeeded.

The HTML pages are in _build/html.
(venv) j@j:~/PycharmProjects/Adafruit_CircuitPython_PN532/docs$

jposada202020 · 2023-03-24T04:25:07Z

It seems that It did not like very much my space add, and now the CI is failing because of that. could you check on your end. thanks

tcfranks · 2023-04-06T18:03:39Z

@jposada202020 I still error out with same errors and no html pages get built. Running Sphinx v6.1.3 Where does this leave us? Is there someone else that can help us out?

tcfranks · 2023-04-07T17:49:30Z

@kattni this is the project - or do you need my side of the branch?

jposada202020 · 2023-04-09T15:38:38Z

Thank you!

Updating https://github.com/adafruit/Adafruit_CircuitPython_PN532 to 2.3.18 from 2.3.17: > Merge pull request adafruit/Adafruit_CircuitPython_PN532#65 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries

add addtional RTD info

008565f

jposada202020 reviewed Mar 20, 2023

View reviewed changes

adafruit_pn532/i2c.py Outdated Show resolved Hide resolved

jposada202020 reviewed Mar 20, 2023

View reviewed changes

adafruit_pn532/i2c.py Outdated Show resolved Hide resolved

jposada202020 reviewed Mar 20, 2023

View reviewed changes

adafruit_pn532/i2c.py Show resolved Hide resolved

jposada202020 reviewed Mar 20, 2023

View reviewed changes

adafruit_pn532/i2c.py Outdated Show resolved Hide resolved

jposada202020 suggested changes Mar 20, 2023

View reviewed changes

changes per comments

1859ca7

jposada202020 reviewed Mar 21, 2023

View reviewed changes

adafruit_pn532/spi.py Show resolved Hide resolved

Update adafruit_pn532/spi.py

8757037

jposada202020 approved these changes Mar 24, 2023

View reviewed changes

jposada202020 and others added 3 commits April 7, 2023 15:26

Update spi.py

58f1c32

changes after local build of RTD and review

2628c4a

Merge remote-tracking branch 'origin/main'

7edf5cf

jposada202020 merged commit 8aa8ac3 into adafruit:main Apr 9, 2023

add addtional RTD info #65

add addtional RTD info #65

Uh oh!

Conversation

tcfranks commented Mar 20, 2023

Uh oh!

tcfranks commented Mar 20, 2023

Uh oh!

jposada202020 commented Mar 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jposada202020 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tcfranks commented Mar 21, 2023

Uh oh!

jposada202020 commented Mar 21, 2023

Uh oh!

jposada202020 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tcfranks commented Mar 23, 2023

Uh oh!

tcfranks commented Mar 23, 2023

Uh oh!

jposada202020 commented Mar 23, 2023

Uh oh!

jposada202020 commented Mar 24, 2023

Uh oh!

tcfranks commented Apr 6, 2023

Uh oh!

tcfranks commented Apr 7, 2023

Uh oh!

jposada202020 commented Apr 9, 2023

Uh oh!

Uh oh!

jposada202020 left a comment •

edited

Loading