Dont require secrets if no network #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested these changes successfully under the following scenarios: Feather S2 TFT - use_network=False and don't call any functions that are network related features -> prints the warning message but does allow the code to complete Feather S2 TFT use_network=False and user code does try to use a network related feature -> raises RuntimeError indicating that network must not be None in order to use that feature. PyPortal Titano - ISS tracking project with normal network configuration -> No change in behavior, works the same as current version of PortalBase. |
makermelissa
approved these changes
Apr 18, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 26, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_SD to 3.3.9 from 3.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_SD#48 from tekktrik/doc/add-typing > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. Updating https://github.com/adafruit/Adafruit_CircuitPython_SharpMemoryDisplay to 1.4.0 from 1.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#21 from tekktrik/dev/switch-bus-device > Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#19 from ilikecake/image-function-numpy > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.13.0 from 1.12.0: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#70 from FoamyGuy/dont_require_secrets_if_no_network > change discord badge > Patch: Replaced discord badge image > Updated gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change goes along with: adafruit/Adafruit_CircuitPython_ESP32S2TFT#6
which allows the user to specify with keyword argument that they don't intend to use the network when they initialize the helper class.
The changes here are checking
self.networkforNoneand raising exceptions any time the user is attempting to use network related features when they previously specified that they weren't going to use the network and thus self.network got set toNone.