Initial PR of PyBadger. #1
Conversation
| return Buttons(*[button_values & button for button in | ||
| (PyBadger.BUTTON_B, PyBadger.BUTTON_A, PyBadger.BUTTON_START, | ||
| PyBadger.BUTTON_SELECT, PyBadger.BUTTON_RIGHT, | ||
| PyBadger.BUTTON_DOWN, PyBadger.BUTTON_UP, PyBadger.BUTTON_LEFT)]) |
There was a problem hiding this comment.
Should this handle the joystick as a directional on pygamer as well?
Why have one property for all buttons instead of 8 separate ones to match circuitplayground?
There was a problem hiding this comment.
I'm not sure how to make it handle the joystick. There's a separate property for the joystick.
I initially had it in separate properties, however calling get_pressed multiple times clears the previous button press. This seemed more efficient and allows for multiple button presses to be maintained.
There was a problem hiding this comment.
I wonder if the multiple press tracking isn't needed for this simple library. Your example code calls get_pressed multiple times anyway.
I imagine having the joystick count as a directional button would be more beneficial because the client code will work on PyGamer and PyBadge without modification.
merge badge changes into clue adaptation
Still a WIP, but passes Pylint and Sphinx builds. Needs more documentation and better example code. PR'd for @ladyada's use.