Thanks to visit codestin.com
Credit goes to github.com

Skip to content

New optional json_transform arg to PyPortal constructor to post-process parsed JSON #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 30, 2019

Conversation

kevinjwalters
Copy link
Contributor

@kevinjwalters kevinjwalters commented May 29, 2019

This is an implementation of json_transform (was json_transforms) described in #38.

Developed for and tested with nasa.py a new version of NASA image viewer from Adafruit Learn: PyPortal NASA Image of the Day Viewer.

That viewer can now cope with YouTube video urls as it can convert them to a url which fetches a single, still image representing the video. See commit history for the version which forces data to 2019-05-20 for a YouTube video. Tested with CircuitPython 4.0.1 on PyPortal.

…ction or list of functions to call with the parsed JSON dict. adafruit#38
@kevinjwalters kevinjwalters changed the title New optional json_transforms arg to PyPortal constructor to post-process parsed JSON New optional json_transform arg to PyPortal constructor to post-process parsed JSON Sep 7, 2019
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. All of @ladyada's comments have been addressed.

@tannewt
Copy link
Member

tannewt commented Sep 30, 2019

Thank you!

@tannewt tannewt merged commit 636609f into adafruit:master Sep 30, 2019
kevinjwalters pushed a commit to kevinjwalters/Adafruit_Learning_System_Guides that referenced this pull request Nov 8, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 13, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.5.1 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#38 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#39 from adafruit/revert-36-bitbangio
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#36 from schelmo/bitbangio
  > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#35 from schelmo/digitalio

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.4 from 3.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#56 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#55 from adafruit/dherrada-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#39 from kevinjwalters/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.1.0 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#20 from Airviz/multiple-featureset-values
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#18 from adafruit/dherrada-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#4 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.9.2 from 0.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#8 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#6 from adafruit/dherrada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants