-
Notifications
You must be signed in to change notification settings - Fork 55
New optional json_transform arg to PyPortal constructor to post-process parsed JSON #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction or list of functions to call with the parsed JSON dict. adafruit#38
3 tasks
…transforms rather than ploughing on. adafruit#38
ladyada
requested changes
Aug 16, 2019
updates since my previous PR
tannewt
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. All of @ladyada's comments have been addressed.
Thank you! |
kevinjwalters
pushed a commit
to kevinjwalters/Adafruit_Learning_System_Guides
that referenced
this pull request
Nov 8, 2019
… (note singular) based on minor rework from adafruit/Adafruit_CircuitPython_PyPortal#39. adafruit#707
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 13, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 1.5.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#38 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#39 from adafruit/revert-36-bitbangio > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#36 from schelmo/bitbangio > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#35 from schelmo/digitalio Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.4 from 3.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#56 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#55 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#39 from kevinjwalters/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.1.0 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#20 from Airviz/multiple-featureset-values > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#18 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#4 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.9.2 from 0.9.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#8 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#6 from adafruit/dherrada-patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of
json_transform
(wasjson_transforms
) described in #38.Developed for and tested with nasa.py a new version of NASA image viewer from Adafruit Learn: PyPortal NASA Image of the Day Viewer.
That viewer can now cope with YouTube video urls as it can convert them to a url which fetches a single, still image representing the video. See commit history for the version which forces data to 2019-05-20 for a YouTube video. Tested with CircuitPython 4.0.1 on PyPortal.