Thanks to visit codestin.com
Credit goes to github.com

Skip to content

startup sound, AP settings notification text, allow background solid fill #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 26, 2019
Merged

startup sound, AP settings notification text, allow background solid fill #4

merged 5 commits into from
Feb 26, 2019

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Feb 24, 2019

  • play a startup sound :D
  • give a good warning experience if AP is not valid or cant connect - uses terminal
  • allowing setting a background color

kattni
kattni suggested changes Feb 24, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a guess at resolving the linting error.

adafruit_pyportal.py Outdated
print("Set background to ", filename)
try:
print("Set background to ", file_or_color)
while len(self._bg_group) != 0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be while len(self._bg_group): but I have no way to test it. If it is = 0 then it is false. So in theory, if it's != 0 it's true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiya im still making changes, and will do all the lints once things work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@ladyada ladyada merged commit 7df38a4 into adafruit:master Feb 26, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 26, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@eab60b0)
f79d7f6 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#9 from demophoon/add-blinka-to-requirements-txt

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#4 from ladyada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#16 from demophoon/add-blinka-to-requirements-txt

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.10 from 2.2.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#25 from demophoon/add-blinka-to-requirements-txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @kattni