Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replaced DummyPin methods and properties #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2019
Merged

Replaced DummyPin methods and properties #26

merged 1 commit into from
May 7, 2019

Conversation

makermelissa
Copy link
Collaborator

Fixes #1.

@makermelissa makermelissa requested a review from a team May 7, 2019 21:16
deshipu
deshipu approved these changes May 7, 2019
View reviewed changes
adafruit_rgb_display/rgb.py

@pull.setter
def pull(self, val):
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could simply have those as class attributes, instead of properties — I suppose not worth the micro-optimization. Something like:

class DummyPin:
    value = None
    direction = None
    pull = None

    def deinit(...

@makermelissa makermelissa merged commit 608dcf4 into adafruit:master May 7, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 8, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@cb62109)
1cb7354 
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.2.3 from 3.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#20 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.2.1 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#26 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.9.0 from 1.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#42 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#41 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#40 from dherrada/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deshipu deshipu deshipu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DummyPin doesn't reflect the pin API
2 participants
@makermelissa @deshipu