Refactor request method to use parse_headers #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscosti
suggested changes
Aug 2, 2019
|
@mscosti Thanks for the review, made requested changes (modified them a bit to work properly). Test transfer-encoding Test HTTP Transfer Requests: |
mscosti
reviewed
Aug 2, 2019
adafruit_requests.py
Outdated
| resp.headers = parse_headers(sock) | ||
| if resp.headers.get("transfer-encoding"): | ||
| if "chunked" in resp.headers.get("transfer-encoding"): | ||
| raise ValueError("Unsupported " + str(line[0])) |
There was a problem hiding this comment.
oh, missed this one on my first pass. I think this is supposed to be the transfer encoding header value in the exception string.
|
@mscosti Moved the header value into the exception string... |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 2, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#11 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#10 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_ILI9341#9 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to v1.1.0 from v1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#7 from brentru/refactor_req > Merge pull request adafruit/Adafruit_CircuitPython_Requests#5 from brentru/add-parse-headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #6
Request now uses
parse_headers.Tested with
WSGIServer.pyon Adafruit CircuitPython 4.0.0 on 2019-05-20; Adafruit PyPortal with samd51j20.https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI/blob/master/examples/server/esp32spi_wsgiserver.py