ShiftIn/ShiftOut #11
Merged
ShiftIn/ShiftOut #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Jul 28, 2017
simpleio.py
Outdated
| @@ -31,9 +31,73 @@ | |||
| """ | |||
|
|
|||
| import digitalio | |||
| import math | |||
There was a problem hiding this comment.
This is needed by neopixel below.
simpleio.py
Outdated
|
|
||
| for i in range(0, 8): | ||
| clock.value = True | ||
| if msb_first == False: |
There was a problem hiding this comment.
I'd reverse this:
if msb_first:
value |= ((dataPin.value) << (7-i))
else:
value |= ((dataPin.value) << i)If tests that are positive are generally easier to read.
simpleio.py
Outdated
|
|
||
| :param dataPin: pin on which to input each bit | ||
| :param clock: toggles to signal dataPin reads | ||
| :param msb_first: order to shift bits (least significant or most significant bit first) |
There was a problem hiding this comment.
I'd change this comment to "True when the first bit is the most significant."
simpleio.py
Outdated
| MSB. | ||
|
|
||
| :param dataPin: pin on which to input each bit | ||
| :param clock: toggles to signal dataPin reads |
There was a problem hiding this comment.
Please add types (digitalio.DigitalInOut) in here.
simpleio.py
Outdated
| :param dataPin: value bits get output on this pin | ||
| :param clock: toggled once the data pin is set | ||
| :param msb_first: order to shift bits (least significant or most significant bit first) | ||
| :param value: byte to be shifted |
simpleio.py
Outdated
| :param msb_first: order to shift bits (least significant or most significant bit first) | ||
| :param value: byte to be shifted | ||
|
|
||
| Example for Metro Express: |
simpleio.py
Outdated
| shiftOut(dataPin, clock, 'LSBFIRST', (valueSend>>8)) | ||
| shiftOut(dataPin, clock, 'LSBFIRST', valueSend) | ||
| shiftOut(dataPin, clock, 'MSBFIRST', (valueSend>>8)) | ||
| shiftOut(dataPin, clock, 'MSBFIRST', valueSend) |
There was a problem hiding this comment.
Update these for the new parameter order please.
simpleio.py
Outdated
| """ | ||
| value = value&0xFF | ||
| for i in range(0, 8): | ||
| if msb_first == False: |
tannewt
requested changes
Jul 28, 2017
tannewt
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shiftIn and shiftOut methods to the SimpleIO library per suggestion #1