Added tone() #12
Added tone() #12
Conversation
simpleio.py
Outdated
|
|
||
| :param pin: pin on which to stop the tone from being played | ||
| """ | ||
| pwm.deinit(pin) |
There was a problem hiding this comment.
Have you tried this? I don't think the pwm object will persist across the tone and noTone calls. It also doesn't take a pin in.
Adding support for the analog out pin would also be nice. PWM doesn't work with it but AudioOut does.
simpleio.py
Outdated
|
|
||
| :param dataPin: pin on which to input each bit | ||
| :param clock: toggles to signal dataPin reads | ||
| :param bitOrder: order to shift bits (either LSBFIRST or MSBFIRST) |
There was a problem hiding this comment.
I'd make this a bool instead of a string and give it a default. So something like msb_first=True.
simpleio.py
Outdated
| :param dataPin: pin on which to input each bit | ||
| :param clock: toggles to signal dataPin reads | ||
| :param bitOrder: order to shift bits (either LSBFIRST or MSBFIRST) | ||
| :param value: RETURNS the value read |
There was a problem hiding this comment.
simpleio.py
Outdated
| clock = digitalio.DigitalInOut(D12) | ||
| dataPin = digitalio.DigitalInOut(D11) | ||
| clock.switch_to_output() | ||
| dataPin.switch_to_output() |
There was a problem hiding this comment.
Lets use the property in examples where we don't provide arguments to switch_to_output.
So it should be clock.direction = digitalio.Direction.OUTPUT
|
Please rebase this now that the shift code is in. |
|
Rebased. |
|
What did you rebase onto? It looks likes the tone branch is still based on a commit from April. The |
b28fac7 to
b74bfb5
Compare
simpleio.py
Outdated
| except ValueError: | ||
| with pulseio.PWMOut(pin, frequency = frequency, variable_frequency = False) as pwm: | ||
| pwm.duty_cycle = 0x8000 | ||
| time.sleep(1) |
… and analog pins.
Added tone() to generate square wave w/50% duty cycle and user-defined frequency. #2