-
Notifications
You must be signed in to change notification settings - Fork 20
Added library name to example filenames #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the new filenames to https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO/blob/master/docs/examples.rst
This is the error Travis is giving me:
I've verified that PWMOut exists, in the pulseio library so I'm not sure what the issue is. I can put in an issue, but I'll have to check using simpleio on a circuitpython board first |
I manually rebuilt |
I looked into at the pylint error earlier, on the other PR (we need to pick one; they're for the same issue). Not sure why its popping up now, and not before. I think the simple answer is to disable pylint for the offending code, which is done in other libraries. try:
# pin with PWM
#pylint: disable=no-member
with pulseio.PWMOut(pin, frequency=int(frequency), variable_frequency=False) as pwm:
pwm.duty_cycle = 0x8000
time.sleep(duration)
#pylint: enable=no-member |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's passing fine now. Thanks
Thanks @dherrada |
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.2.3 from 3.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#20 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.2.1 from 3.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#26 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.9.0 from 1.8.1: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#42 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#41 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#40 from dherrada/master
No description provided.