Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added library name to example filenames #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2019
Merged

Added library name to example filenames #40

merged 3 commits into from
May 7, 2019

Conversation

evaherrada
Copy link
Collaborator

No description provided.

@brentru brentru requested a review from a team May 6, 2019 20:49
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evaherrada
Copy link
Collaborator Author

This is the error Travis is giving me:

E: 53,13: Module 'pulseio' has no 'PWMOut' member (no-member)
The command "pylint simpleio.py" exited with 2.

I've verified that PWMOut exists, in the pulseio library so I'm not sure what the issue is. I can put in an issue, but I'll have to check using simpleio on a circuitpython board first

@brentru
Copy link
Member

brentru commented May 6, 2019

I manually rebuilt master on Travis and it looks like this library hits a similar issue there:
https://travis-ci.com/adafruit/Adafruit_CircuitPython_SimpleIO/jobs/198065217#L571

@sommersoft
Copy link
Collaborator

I looked into at the pylint error earlier, on the other PR (we need to pick one; they're for the same issue).

Not sure why its popping up now, and not before.

I think the simple answer is to disable pylint for the offending code, which is done in other libraries.
Line 53 in simpleio.py:

try:
    # pin with PWM
    #pylint: disable=no-member
    with pulseio.PWMOut(pin, frequency=int(frequency), variable_frequency=False) as pwm:
        pwm.duty_cycle = 0x8000
        time.sleep(duration)
    #pylint: enable=no-member

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's passing fine now. Thanks

@makermelissa makermelissa merged commit ecbd27a into adafruit:master May 7, 2019
@makermelissa
Copy link
Collaborator

Thanks @dherrada

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 8, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.2.3 from 3.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#20 from dherrada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.2.1 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#26 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.9.0 from 1.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#42 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#41 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#40 from dherrada/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants