Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

BlitzCityDIY
Copy link
Contributor

No description provided.

@BlitzCityDIY
Copy link
Contributor Author

@ladyada TLV320 circuitpython library

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tweak the property comments to not start with "Get", "Set" or "Read". The action is implicit in the use. Instead just do "The current volume...".

Looking at the generated docs can help understand the API you are creating and how it looks from "the outside.".

@BlitzCityDIY BlitzCityDIY requested review from tannewt and removed request for tannewt March 19, 2025 19:04
@BlitzCityDIY BlitzCityDIY marked this pull request as draft March 19, 2025 21:50
@BlitzCityDIY
Copy link
Contributor Author

BlitzCityDIY commented Mar 19, 2025

i'm having some weirdness with speaker output on the rev b so putting into draft after some more troubleshooting with the breakout

tested with rev b fruit jam
@BlitzCityDIY BlitzCityDIY marked this pull request as ready for review March 21, 2025 21:06
@BlitzCityDIY BlitzCityDIY requested a review from tannewt March 21, 2025 21:06
@BlitzCityDIY
Copy link
Contributor Author

the speaker issue with the breakout was because i was powering with 3.3V vs. 5V (5V needed for speaker). additionally, needed to be calling self.left_dac_channel_volume and self.right_dac_channel_volume which are included in the speaker_output helper now.

last weird thing is i'm only getting audio out of headphone left on fruit jam rev b. i get stereo headphone out on fruit jam rev a and the breakout

@ladyada
Copy link
Member

ladyada commented Mar 23, 2025

ooh what about the breakout?

@BlitzCityDIY
Copy link
Contributor Author

@ladyada yes tlv320 breakout has audio coming out left and right channels on the headphones (tested with metro rp2350). haven't been able to get any audio out of the right channel on fruit jam rev b.

@ladyada
Copy link
Member

ladyada commented Mar 24, 2025

ok probably a hardware/soldering/design issue - trust the breakout :)

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing. Good otherwise!

Co-authored-by: Scott Shawcroft <[email protected]>
@BlitzCityDIY BlitzCityDIY requested a review from tannewt March 31, 2025 20:13
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 2f3491c into main Apr 1, 2025
2 checks passed
@BlitzCityDIY BlitzCityDIY deleted the initial_lib branch April 1, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants