updated comments to reflect AU915 frequencies fixes#8 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good (checked freqs. against the arduino implementation), thanks for the PR. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 20, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#12 from brentru/fix-freq-comments > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#11 from brentru/example-spi-ordering > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#10 from philwilkinson40/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#6 from brentru/readme-modification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to be clear, this pull is only to amend the comments, to bring them in line with the actual frequencies used. This is really to avoid lots of confusion if users have trouble connecting to TheThingsNetwork and think the frequencies are wrong in TinyLoRa.