-
Notifications
You must be signed in to change notification settings - Fork 9
Remove interrupt support (no interrupt on chip or breakout) #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.5.15 from 2.5.14: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#60 from regicidalplutophage/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#31 from adafruit/anecdata-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
I don't think you made the right thing by removing the interrupts notion. They are usable even if there is no dedicated pin. The chip has a feature of setting the interrupt bits (in the ALS_INT register) with persistence protection (ALS_PERS) which you can read instead of the ALS register. This is helpful for continuous ambient light tracking with smoothing done by VEML7700 instead of your custom logic that would require more I2C communication. |
@RaNo99 Sorry I missed your comment earlier. Was the old code OK as-is for that purpose? Would you be willing to submit an example that illustrates the use case? We can revert the deletions. |
Hi, yes, I tried the old version and it indeed worked. Then I had to resort to a non-interrupt solution because I needed more flexibility, so I don't have the code example anymore. |
yes please revert - better to add documentation to the readme explaining there's no external IRQ |
Revert #31 to re-enable chip-internal interrupt features
Remove mentions and register settings for interrupts. The chip only has power, ground, SDA, and SCL. No interrupt pin on breakout either.
The datasheet notes on p.7:
The docs were confusing for including (unsupported) interrupt features.