Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

anecdata
Copy link
Member

@anecdata anecdata commented Oct 7, 2024

Remove mentions and register settings for interrupts. The chip only has power, ground, SDA, and SCL. No interrupt pin on breakout either.

The datasheet notes on p.7:

Interrupt pin not available for VEML7700

The docs were confusing for including (unsupported) interrupt features.

Copy link

github-actions bot commented Oct 7, 2024

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FoamyGuy FoamyGuy merged commit 386669d into main Oct 8, 2024
2 checks passed
@anecdata anecdata deleted the anecdata-patch-1 branch October 8, 2024 15:00
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 9, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.5.15 from 2.5.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#60 from regicidalplutophage/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 2.0.2 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#31 from adafruit/anecdata-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
@RaNo99
Copy link

RaNo99 commented Jun 11, 2025

I don't think you made the right thing by removing the interrupts notion. They are usable even if there is no dedicated pin. The chip has a feature of setting the interrupt bits (in the ALS_INT register) with persistence protection (ALS_PERS) which you can read instead of the ALS register. This is helpful for continuous ambient light tracking with smoothing done by VEML7700 instead of your custom logic that would require more I2C communication.

@anecdata
Copy link
Member Author

anecdata commented Sep 2, 2025

@RaNo99 Sorry I missed your comment earlier. Was the old code OK as-is for that purpose? Would you be willing to submit an example that illustrates the use case? We can revert the deletions.

@RaNo99
Copy link

RaNo99 commented Sep 2, 2025

Hi, yes, I tried the old version and it indeed worked. Then I had to resort to a non-interrupt solution because I needed more flexibility, so I don't have the code example anymore.

@ladyada
Copy link
Member

ladyada commented Sep 3, 2025

yes please revert - better to add documentation to the readme explaining there's no external IRQ

tannewt added a commit that referenced this pull request Sep 4, 2025
Revert #31 to re-enable chip-internal interrupt features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants