Add ability to draw circle #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
requested changes
Oct 22, 2019
adafruit_framebuf.py
Outdated
| @@ -215,6 +215,32 @@ def vline(self, x, y, height, color): | |||
| """Draw a vertical line up to a given length.""" | |||
| self.rect(x, y, 1, height, color, fill=True) | |||
|
|
|||
| def circle(self, center_x, center_y, radius, color): | |||
| """Draw a circle at the given midpoint location, radius and color. The ```circle``` method draws only | |||
There was a problem hiding this comment.
It looks like this line is too long. Simple fix. Just take some of the text off the end and add it in front of the text on the line below.
|
Thanks @makermelissa I think that worked properly, if not, let me know. |
makermelissa
approved these changes
Oct 22, 2019
|
Thanks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 22, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.5.0 from 2.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#33 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_EPD#32 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_EPD#29 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#24 from boo13/draw-circle > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#23 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_framebuf#22 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_MCP9600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Long time listener/fan of Adafruit - first time contributor!
Based on code from here: https://github.com/adafruit/Adafruit_CircuitPython_SSD1306/blob/master/examples/ssd1306_bouncing_ball.py
I tested it using the above 'bouncing ball' example, but frankly could not figure out how to test this library change using the build tools yet.
Appreciate all of your hard work and any feedback!
PS - A special thank you to @kattni for the wonderful guide to contributing