Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update sha1 constructor #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Conversation

brentru
Copy link
Member

@brentru brentru commented Dec 27, 2019

SHA1 constructor now accepts optional data kwarg to reflect CPython's hashlib api: hashlib.sha1(name[, data]). This constructor now reflects the other sha module constructors within this library.

Output from Adafruit CircuitPython 5.0.0-beta.2 on 2019-12-20; Adafruit PyPortal with samd51j20

>>> hashlib.sha1(b"data!")
<sha1 object at 2002c2d0>
>>> hashlib.sha1(b"data!").hexdigest()
'cd3618849b8025aa2d5da3f33d7311d31f66e677'

@brentru brentru requested a review from a team December 27, 2019 18:03
@brentru brentru merged commit 5210b90 into adafruit:master Dec 27, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 28, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to 1.2.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#7 from brentru/add-argument-to-sha1
  > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#6 from brentru/add-sha-1
  > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#4 from adafruit/dherrada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants