minimal QR code generator and drawing examples #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Sep 17, 2018
adafruit_miniqr.py
Outdated
| self.data_cache = QRCode.create_data(self.type, self.ECC, self.data_list) | ||
| self.map_data(self.data_cache, mask_pattern) | ||
|
|
||
| def setup_position_probe_pattern(self, row, col): |
There was a problem hiding this comment.
Should all of these start with _ to be private? This is an interesting API comparison: https://github.com/lincolnloop/python-qrcode
There was a problem hiding this comment.
i dont know if you'd ever wanna use them outside the library but i could do it sure - i ported this, which i think is a port of the above
https://github.com/SHA2017-badge/micropython-examples-sha2017/tree/master/QRcode
There was a problem hiding this comment.
Do you want to change it now or wait? I was thinking its a good change because it reduces the public API complexity.
There was a problem hiding this comment.
yeah ill do it now one minute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.