Add VOLTAGE_MONITOR pin to feather boards pins #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's called |
|
@dhalbert Please rereview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #1149
I choose VOLTAGE_MONITOR like the Feather M4 Express, over BATTERY like the Hallowing.
VOLTAGE_MONITOR is longer look less ambiguous to me (for me the BATTERY pin could be the pin where I connect a battery, not the pin to monitor it) but I did not change the hallowing to avoid breaking anything.
I only tested on my Feather M0 Express.
I didn't change the pins of boards I didn't found in the learning system guides.