Minor improvements #1527
Merged
Minor improvements #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… space. Signed-off-by: Lionel Debroux <[email protected]>
Signed-off-by: Lionel Debroux <[email protected]>
|
just wanted to say thank you, and this is very cool and interesting! |
tannewt
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Yay! Thank you! You may want to see if any more recent changes to the libm source are helpful to you. It looks like it came from here: http://www.musl-libc.org/ More updates to it are welcome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to hack up a third-party DPFP-based version of CircuitPython for the Trinket M0 compatible TI-Python Adapter, because SPFP just doesn't make the cut for math purposes (it can easily yield wrong results for high school level math problems, i.e. the target audience of this thing; all other calculator-based implementations of Python use DPFP, for excellent reason !), I stumbled across a couple shadowing variables, and most of all, several variables which can be made "static" to save a bit of space: 100+ bytes in my build with Debian sid's arm-non-eabi-gcc (GCC 7.3). So I'm sending a quick PR to improve those.
I know little about the code of MicroPython or CircuitPython. I'm doing that work on my free time for users who bought this underwhelming thing (at least, when equipped with the version of the official firmware contained in the first TI-Python Adapters which reached buyers last week) which cannot even be used from a TI-83 Premium CE calculator yet because the "PyAdaptr" software isn't available. Of course, I'm also indirectly working for TI if they pull in some of these changes...
While working on various pieces of OSS related to TI graphing calculators for 17+ years, I've never signed a NDA with TI EdTech, or received money from TI. At the time of this writing, I don't own a TI-Python Adapter, or a Trinket M0.
If you're curious about what kind of a hacky job I did to cram a DPFP-based build onto a Trinket M0-class platform, you can check the master branch in my repo. At least, it builds, the binary running on a TI-Python Adapter or a Trinket M0 produces reasonable results for FP operations, and benchmarks can be made. My work can certainly be made better, I'm all ears :)