nRF: PWMOut: At deinit, make pin available again #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may affect 4.x. If so it is likely to be trivial to make a new request to fix it there. Please let me know if this is desirable. |
|
Would you mind making it against 4.1.x first and then we'll merge everything from there? |
|
Actually, I'm going to merge now because I'm going to release Alpha.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing performed: Both my minimal reproducer and the
simpleioreproducer from @kattni now work on my Particle Xenon. Besides not giving errors, thesimpleioreproducer shows a succession of tones on my oscilloscope.Closes: #2146