Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update ulab #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 17, 2020
Merged

update ulab #2711

merged 7 commits into from
Mar 17, 2020

Conversation

jepler
Copy link

@jepler jepler commented Mar 16, 2020

This pulls in all of @v923z's updates to ulab so that we can check that they build. It also needs:

  • testing
  • doc updates in the CPy copy of the documentation

before it can be merged.

@jepler jepler requested a review from tannewt March 17, 2020 15:28
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are so many translation entries deleted? One typo in docs.

@jepler
Copy link
Author

jepler commented Mar 17, 2020

Why are so many translation entries deleted?

The rename of ports/stm32f4, but TRANSLATE_SOURCES was not updated

@jepler
Copy link
Author

jepler commented Mar 17, 2020

I added a commit to address that, lmk if you want me to split it into its own PR.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Totally ok to have the translation fix here. Thanks!

@tannewt tannewt merged commit 4603c6d into adafruit:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants