mimxrt10xx: Busio cleanup and bugfixes #2964
Conversation
|
Please let me know when the UART changes are excluded from this diff and I'll take a look. Thanks! |
|
Why does this resolve #2478? 😅 |
|
@arturo182 Haven't found issues so far. Waiting on really stress testing it again until after I solve the other bugs but I'd like to include it as a part of this cleanup. I'd like to get rid of any issue that's just "I haven't checked this 100% yet" and replace it with real bugs if necessary. |
|
Ah I see, makes sense, was just confused how busio cleanup was resolving AnalogIn testing, but now I get that this is more of a general cleanup :) |
|
@tannewt @arturo182 Ok, I think this should be good to go. I've run quite a lot of tests on all the Busio modules along with DigitalIO and AnalogIO, and I've only had one breakout issue so far (#2977). Everything else seems to be pretty good - DigitalIO has all the right pullup and drive behavior, AnalogIO gets good resolution, and Busio works as expected on everything but the displays. Since I was running so many comparisons, I also dug up some STM32 issues while working on this. Seems like that might be the next thing in need of a cleanup... |
This PR issues a general cleanup of the BusIO module to account for recent changes to the pin claiming structure, and issues fixes to a number of bugs and other minor feature requests. All changes are being stress-tested across I2C, SPI, UART, and DigitalIO to hit a baseline level of guaranteed functionality.
It is not currently ready for merge as I'm still tangling with a number of serious issues during testing, including an ugly startup hang, but I'm opening it up to style review and other concerns.
Resolves: #2485
Resolves: #2483
Resolves: #2480
Resolves: #2478