Include wifi.radio singleton in gc #3799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wifi.radiosingleton object, which is in static storage, was not included in GC scanning. It does include one Python object.It could have been added to
ROOT_POINTERS, but instead I added a module-specific GC routine, as has been done in, for example,displayioand_bleiofor similar static objects.I hoped this might fix the ESP32-S2 I2C/WiFi hang. It didn't, sadly. But I think this is still necessary, unless my understanding about what needs to be scanned for GC is confused. (I keep having to re-derive this in my head.)