fix list of modules for alias boards #4507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8366b5c to
032209e
Compare
032209e to
f143e5d
Compare
jepler
requested changes
Mar 29, 2021
will raise an error during build if things as not as expected as suggested by @jepler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alias boards (different name for identical build) did not have their modules listed, due to looking for the directory by the name of the alias (doesn't exist), instead of the original it copies from.
circuitplayground_express_4h,circuitplayground_express_digikey_pycon2019,edgebadge,pyportal_pynt,gemma_m0_pycon2018,pewpew13.Thanks @lesamouraipourpre for signaling.
Note: that only impacts future releases (stable or not)