Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix dependencies for translate.c again #6466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fix dependencies for translate.c again #6466

merged 1 commit into from
Jun 7, 2022

Conversation

jepler
Copy link

@jepler jepler commented Jun 7, 2022

I noticed a problem with building CircuitPython "unix port" for testing over in jepler_udecimal. I believe this change will fix it. The makefile rule referred to an incorrect path, but make cannot detect this type of mistake.

Typical error:

../../supervisor/shared/translate/translate.c:45:35: error: unknown type name ‘mchar_t’
   45 | STATIC void get_word(int n, const mchar_t **pos, const mchar_t **end) {
      |                                   ^~~~~~~

from https://github.com/jepler/Jepler_CircuitPython_udecimal/runs/6768034105?check_suite_focus=true

dhalbert
dhalbert approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit 9d64ea2 into adafruit:main Jun 7, 2022
@jepler jepler deleted the fix-translate-dependency branch June 8, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @dhalbert