Thanks to visit codestin.com
Credit goes to github.com

Skip to content

_stage: use 16 bit for coordinates to support larger screens #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2018
Merged

_stage: use 16 bit for coordinates to support larger screens #667

merged 1 commit into from
Mar 12, 2018

Conversation

deshipu
Copy link

@deshipu deshipu commented Mar 11, 2018

No description provided.

@dhalbert
Copy link
Collaborator

Do the x,y and width,height types in Layer.h and Text.h need to change as well?

@tannewt tannewt requested a review from dhalbert March 12, 2018 20:34
@tannewt tannewt added this to the 2.x milestone Mar 12, 2018
@deshipu
Copy link
Author

deshipu commented Mar 12, 2018

No, those are in tiles (16×16), not pixels, so they are fine at least until we have 4096×4096 screens (and enough memory to handle them).

dhalbert
dhalbert approved these changes Mar 12, 2018
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dhalbert dhalbert merged commit cfcbb36 into adafruit:2.x Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.x
Development

Successfully merging this pull request may close these issues.
3 participants
@deshipu @dhalbert @tannewt