PacketBuffer ringbuf size #6800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Aug 25, 2022
|
I have a much better fix in #6214, which was closed because it was too dangerous to incorporate in a 7.3.x point release. But I opened #6815 to remind me to bring in the #6214 changes to I think the byte vs 16-bit int does not make a difference for this |
|
I did test this with the #6786 tests. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ringbuf for a fixed-size
PacketBufferwas one byte too small.I have a better cleanup for
ringbufwhich will also fix this problem in #6214, but it was a big change which I deferred tomainand then forgot to add after doing #6238 instead for 7.x.x. I will make another PR formainthat incorporates the fixes from #6214.