Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix bindings typing #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2022
Merged

Fix bindings typing #6905

merged 1 commit into from
Sep 15, 2022

Conversation

TimonPeng
Copy link

@TimonPeng TimonPeng commented Sep 15, 2022 •
edited
Loading

Hi, we create a Type support (typings) package for CircuitPython built-in binding packages: types-circuitpython

So fixed some typings typo throw by pyright check.

dhalbert
dhalbert approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding these missing Optional[] things!

@dhalbert dhalbert merged commit f1d592a into adafruit:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimonPeng @dhalbert