-
Notifications
You must be signed in to change notification settings - Fork 641
Rename master to main #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is a reference in
|
I've updated that to use v2 of the checkout action. |
Shouldn't this be |
|
Slight misunderstanding on my part. As Dan said, I think |
What's needed to move this forward? |
As of the PR release, I think we just needed to check that any bots pushing to this repo were using main instead of master? I'm not really sure. The changes in this PR should still be OK, but we'll need to update any newly added board files still referencing master. |
I've just synced it up with master and updated any new files. This PR is now back up to date. @makermelissa @tannewt is there anything else we need to do to get this one in? Any adabot changes? Edit: I see we were waiting on #711, which appears to be ready now, maybe. |
On the Blinka devices there is a link near the bottom of their MD files: The URL for that link appears to have the
There are a few places in this guide where the same thing could get updated: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-blinka Maybe some or all of the non-blinka microcontrollers have this as well I haven't done a thorough check, but Feather Express M4 does have a similar link that could get updated. This process could probably be automated fairly easily instead of trying to do all of them "by hand" |
@FoamyGuy those should all be synced up now as well. |
Ah, that is right, I see them in the changes now. @jwcooper thank you. Updating the accompanying example file references on these pages: https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-downloads https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-blinka were the only two places I found in Learn Guides that may need updated to match when the time comes. |
still another conflict :-/ |
I changed the name to raspberry_pi_cm4io (and the content) to reflect the fact that we have multiple carrier boards that can run the compute module 4. |
@jepler @makermelissa this should be ready again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Jeff is out on vacation.
I don't think we need to wait for Jeff. It's been reviewed. You could merge and we will see that it works or not, and fix it. |
I'm ok with merging this. |
I renamed the default branch now to |
This depends on solving all outstanding issues in the following issue:
#711