update from uap-core from 0.6.7 to 0.6.9 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
abandoning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building off your work to update to uap-core 0.6.7, this takes us up to 0.6.9. Changes seem to mainly be in parts of the parser previously un-exercised by the test suite - the 3 test failures I found were two issues of empty string where None was required, and one where $2 and $3 were poking through in the OS detection for
"MacOutlook/16.12.0.180401 (Intelx64 Mac OS X Version 10.12.6 (build 16G29))"so I repurposed the logic for dealing with those expressions in DeviceParser for OSParser as well.
I'd really like to get this into uap-parser/uap-go but as they haven't merged ua-parser#70 yet, I figured it was at least worth sharing here if you wanted to merge it into your fork.