2412 correct order for listversions #2413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was by order of creation, now reversed which matches S3 APIs. Fixes #2412
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ordering of versions returned by listVersions, updates related integration tests, and increments the project’s version to 4.4.0-SNAPSHOT across POMs and the changelog.
- Reverse the iteration order in
BucketService.listVersionsso that the newest versions appear first. - Update
ListObjectVersionsITto assert the new ordering. - Bump all module versions to 4.4.0-SNAPSHOT and update the CHANGELOG (introduce 4.5.0 planned, finalize 4.4.0).
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testsupport/testng/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| testsupport/testcontainers/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| testsupport/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| testsupport/junit5/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| testsupport/junit4/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| testsupport/common/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| server/src/main/java/com/adobe/testing/s3mock/service/BucketService.java | Reverse the list of object versions before iterating |
| server/src/main/java/com/adobe/testing/s3mock/S3MockApplication.java | Remove obsolete Spring Security exclusion and update copyright |
| server/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| pom.xml | Bump version to 4.4.0-SNAPSHOT; add dependency plugin management |
| integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/ListObjectVersionsIT.kt | Update and add assertions for correct version ordering |
| integration-tests/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| docker/pom.xml | Remove explicit maven-dependency-plugin version (inherited) |
| build-config/pom.xml | Bump parent version to 4.4.0-SNAPSHOT |
| CHANGELOG.md | Add 4.5.0 planned section and finalize 4.4.0 release notes |
Comments suppressed due to low confidence (1)
server/src/main/java/com/adobe/testing/s3mock/service/BucketService.java:60
- The import java.util.Comparator is no longer used after reversing the versions list; consider removing this unused import.
import java.util.Comparator;
integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/ListObjectVersionsIT.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix order of ListObjectVersions
Related Issue
Fixes #2412
Tasks