Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ACNA-2802 - code links in README point to a .ts file #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shazron merged 2 commits into from
Feb 6, 2024
Merged

fix: ACNA-2802 - code links in README point to a .ts file #127

shazron merged 2 commits into from
Feb 6, 2024

Conversation

@shazron
Copy link
Member

@shazron shazron commented Feb 2, 2024

closes #126

How Has This Been Tested?

  1. rm -rf node_modules
  2. npm i
  3. npm test
  4. npm run prepack
  5. Inspect README.md for See code: links (should point to the .js file)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b1bd0e) 100.00% compared to head (48d782a) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          152       152           
  Branches        33        33           
=========================================
  Hits           152       152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron merged commit d8b034e into master Feb 6, 2024
@shazron shazron deleted the story/ACNA-2802 branch February 6, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amulyakashyap09 amulyakashyap09 amulyakashyap09 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

auth plugin: code links in README point to a .ts file

3 participants

@shazron @amulyakashyap09