Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix for <unsupported file index> issue with DWARF5 debug data #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

Fix for <unsupported file index> issue with DWARF5 debug data #92

merged 2 commits into from
May 9, 2025

Conversation

fosterbrereton
Copy link
Contributor

@fosterbrereton fosterbrereton commented May 7, 2025 •
edited
Loading

We were getting reports of ORC failing to enumerate files properly, looking something like:

error: ODRV (structure:byte_size); 2 conflicts with `ZSTD_parameters`
    byte_size: 32 (0x20)
    symbol defintion location(s):
            <unsupported file index>:206 (used by `libzstd.a -> zstd_v04.c.o` and 0 others)

    byte_size: 40 (0x28)
    symbol defintion location(s):
            <unsupported file index>:1305 (used by `libzstd.a -> zdict.c.o` and 1 others)

This was due to extensive changes between DWARF4 and DWARF5 with respect to the line number program header, which is where file paths are stored. This update adds additional logic to the line_header reading code that accommodates the new structure.

@fosterbrereton fosterbrereton requested a review from leethomason May 7, 2025 23:54
leethomason
leethomason approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@leethomason leethomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the fixes!

@fosterbrereton fosterbrereton merged commit 1db995c into main May 9, 2025
3 checks passed
@fosterbrereton fosterbrereton deleted the fosterbrereton/unsupported-file-index-fix branch May 9, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leethomason leethomason leethomason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fosterbrereton @leethomason