putting a comment back in

adobe · fosterbrereton · May 16, 2025 · May 5, 2025 · May 5, 2025 · May 5, 2025
commit 67aaaae3b92c815b9075f3bd1f2e6f59b88affbe
diff --git a/include/orc/dwarf_structs.hpp b/include/orc/dwarf_structs.hpp
@@ -177,14 +177,19 @@ std::ostream& operator<<(std::ostream& s, const attribute& x);
 
 //--------------------------------------------------------------------------------------------------
 // I'm not a fan of the name `attribute_sequence`.
+//
+// TODO: Consider using `std::array` instead of `std::vector` to avoid dynamic allocation. This
+// would require we cap the max number of attributes at compile time, which should be okay as long
+// as we pick a reasonable number. On the other hand, that would make DIEs with smaller sets of
+// attributes less memory efficient. It's the classic space/time tradeoff.
 struct attribute_sequence {
     using attributes_type = std::vector<attribute>;
     using value_type = typename attributes_type::value_type;
     using iterator = typename attributes_type::iterator;
     using const_iterator = typename attributes_type::const_iterator;
 
-    void reserve(std::size_t n) {
-        _attributes.reserve(n);
+    void reserve(std::size_t size) {
+        _attributes.reserve(size);
     }
 
     bool has(dw::at name) const {