fix(combobox): close ComboBox popover on ModalOverlay interaction#10163
Open
EduardF1 wants to merge 1 commit into
Open
fix(combobox): close ComboBox popover on ModalOverlay interaction#10163EduardF1 wants to merge 1 commit into
EduardF1 wants to merge 1 commit into
Conversation
…king properly Fixes adobe#10074
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10074
Currently, clicking a
ModalOverlaydoes not close an open ComboBox whenmenuTrigger='focus'. This regression was introduced by PR #9768 which removed the internaluseInteractOutsidebinding insideuseComboBox.ts.This patch surgicaly restores the
useInteractOutsidehook insideuseComboBoxto correctly capture outer interactions. Since ComboBoxes are naturally non-modal, relying onusePopover's internal dismissability isn't sufficient when paired inside complex Dialog overlays.Testing
Verified code against #9646.