[MWPW-185403] Preflight Link check error message incorrectly assumes VPN issue for all connection failures #5259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
This PR is being Merged into |
skholkhojaev
commented
Dec 16, 2025
libs/blocks/preflight/checks/seo.js
Outdated
| } catch (e) { | ||
| window.lana.log(`There was a problem connecting to the link check API ${url}. ${e}`, { tags: 'preflight', errorType: 'i' }); | ||
| return false; | ||
| return { success: false, isVpnError: false }; |
Contributor
Author
There was a problem hiding this comment.
the logic here is a bit "made up" and has assumptions
"if the request goes through and we get a repsonse = its either a 200 which is great, or 401, 403 status which we assume to be vpn problem"
"if we get no response from the request that we sent = server has issues"
mokimo
reviewed
Dec 16, 2025
mokimo
reviewed
Dec 16, 2025
Contributor
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Contributor
|
Closing this PR due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Spidy link check service fails to connect, the preflight panel always displays "A VPN connection is required to use the link check service. Please turn on VPN and refresh the page." This message is misleading because the connection failure could be caused by reasons other than VPN.
Resolves: MWPW-185403
Test URLs:
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://VPN-error-handling--milo--adobecom.aem.page/?martech=off
Before: https://main--dc--adobecom.aem.page/acrobat?milolibs=LinkCheckerFix--milo--adobecom
After: https://main--dc--adobecom.aem.page/acrobat?milolibs=VPN-error-handling--milo--adobecom