Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

lounsbrough
Copy link

This PR resolves #4543

This is the result of running sass-migrator division **/*.scss

https://www.npmjs.com/package/sass-migrator

@TheSeg
Copy link

TheSeg commented Jun 29, 2021

Switching to multiplication where possible is the right move. The only issue with the approach using math.div is that Libsass projects will break. While the best choice for everyone is to move away from Libsass, using math.div is more breaking than meets the eye.

The Bootstrap project solved this situation by creating a custom divide() function for these situations. That way you still get division while not requiring @use "sass:math";. Everyone wins!

@makinggoodsoftware
Copy link
Contributor

Hi,

Thanks for submitting this PR, at the moment we don’t have a safe mechanism to automatically merge these, but we do this manually instead.

At this stage, your PR is being considered, we should update you as soon as possible, if this PR were to be approved note that we would do this in our end manually and we would close this, but you would get your changes effectively into our source code.

At the moment this is going to be flagged with ag-grid engaged

Thanks for your collaboration!

@gportela85
Copy link
Member

@lounsbrough Thanks for submitting this PR but merging this would actually break our build as is. This PR is also updating files within the dist folder.

We are already tracking a ticket for this issue and it will be fixed in the next release.

@gportela85 gportela85 closed this Jul 1, 2021
@lounsbrough
Copy link
Author

@gportela85 thanks for the update, much appreciated!

@lounsbrough lounsbrough deleted the remove-division branch July 2, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
5 participants