Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(proto): make generation script cross-platform#1769

Merged
maxkorp merged 1 commit into
ag-ui-protocol:mainfrom
he-yufeng:fix/proto-generate-cross-platform-clean
May 27, 2026
Merged

fix(proto): make generation script cross-platform#1769
maxkorp merged 1 commit into
ag-ui-protocol:mainfrom
he-yufeng:fix/proto-generate-cross-platform-clean

Conversation

@he-yufeng

Copy link
Copy Markdown
Contributor

Summary

  • replace the proto package's Unix-only mkdir -p shell snippet with a small Node generation script
  • keep the existing protoc / ts-proto arguments and choose the Windows .CMD plugin shim only on Windows
  • leave generated files untouched; local generation only changed protobuf comment text because the installed protoc package version differs from the checked-in output

Fixes #1552

Verification

  • pnpm --filter @ag-ui/proto generate
  • pnpm --filter @ag-ui/proto build
  • pnpm --filter @ag-ui/proto test
  • pnpm exec prettier --check sdks/typescript/packages/proto/package.json sdks/typescript/packages/proto/scripts/generate.mjs
  • node --check sdks\typescript\packages\proto\scripts\generate.mjs
  • git diff --check

Note

  • pnpm --filter @ag-ui/proto lint currently fails locally because eslint is not available to the proto workspace script even after pnpm install --frozen-lockfile; no lintable source files were changed.

@he-yufeng he-yufeng requested a review from a team as a code owner May 24, 2026 15:22
@vercel

vercel Bot commented May 24, 2026

Copy link
Copy Markdown

@he-yufeng is attempting to deploy a commit to the CopilotKit Team on Vercel.

A member of the Team first needs to authorize it.

@maxkorp maxkorp force-pushed the fix/proto-generate-cross-platform-clean branch from e8347a0 to 8fec951 Compare May 27, 2026 15:18
@maxkorp maxkorp merged commit 282291e into ag-ui-protocol:main May 27, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: sdks:typescript:packages:proto generate uses mkdir -p which is Unix-only

2 participants