Fix: Correct RPC method call in setSessionModel#7
Merged
benbrandt merged 1 commit intoagentclientprotocol:mainfrom Oct 21, 2025
Merged
Fix: Correct RPC method call in setSessionModel#7benbrandt merged 1 commit intoagentclientprotocol:mainfrom
benbrandt merged 1 commit intoagentclientprotocol:mainfrom
Conversation
The setSessionModel method was incorrectly calling session_set_mode instead of session_set_model, causing parameter validation errors. Changed line 598 in src/acp.ts to use the correct RPC method. Fixes: Parameter validation error when calling setSessionModel()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
ClientSideConnection.setSessionModel()where it incorrectly callssession/set_modeinstead ofsession/set_model.Problem
The
setSessionModel()method was calling the wrong RPC method (session_set_mode), which caused parameter validation failures because the server expectedmodeIdinstead ofmodelId.Solution
Changed line 598 in
src/acp.tsto call the correct RPC method:schema.AGENT_METHODS.session_set_modelChanges
src/acp.tssession_set_mode→session_set_modelCode Diff
async setSessionModel( params: schema.SetSessionModelRequest ): Promise<schema.SetSessionModelResponse> { return ( (await this.#connection.sendRequest( - schema.AGENT_METHODS.session_set_mode, + schema.AGENT_METHODS.session_set_model, params )) ?? {} ); }