fix(skill): ignore complex YAML frontmatter to prevent parsing errors#1043
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes MarkdownSkillParser more tolerant of complex/invalid YAML frontmatter by skipping unsupported lines instead of throwing, so skills with non-flat frontmatter won’t block loading.
Changes:
- Updated
SimpleYamlParserto skip non-key: valueYAML lines and avoid throwing on unsupported structures. - Added/updated unit tests to assert “graceful ignore” behavior for invalid lines and list-style YAML in frontmatter.
- Adjusted empty-value generation/parsing expectations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/skill/util/MarkdownSkillParser.java | Makes YAML parsing tolerant by skipping unsupported lines/structures and adds debug logging. |
| agentscope-core/src/test/java/io/agentscope/core/skill/util/MarkdownSkillParserTest.java | Updates tests to validate non-throwing behavior and adds a complex-frontmatter parsing scenario. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@fang-tech PTAL Thanks. |
fang-tech
approved these changes
Mar 28, 2026
liangxingguang
pushed a commit
to liangxingguang/agentscope-java
that referenced
this pull request
May 21, 2026
…agentscope-ai#1043) ## Description Close agentscope-ai#1030 This PR updates the internal `SimpleYamlParser` to gracefully skip unsupported block-style complex structures (like lists or nested objects) instead of throwing exceptions. ## Checklist Please check the following items before code is ready to be reviewed. - [ ] Code has been formatted with `mvn spotless:apply` - [ ] All tests are passing (`mvn test`) - [ ] Javadoc comments are complete and follow project conventions - [ ] Related documentation has been updated (e.g. links, examples, etc.) - [ ] Code is ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #1030
This PR updates the internal
SimpleYamlParserto gracefully skip unsupported block-style complex structures (like lists or nested objects) instead of throwing exceptions.Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)