feat(formatter): support both reasoning_content and reasoning fields for deserialization#1086
Merged
Merged
Conversation
…for deserialization Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Adds backward/forward compatibility for “thinking/reasoning” fields across OpenAI-compatible payloads by allowing deserialization from either reasoning_content or reasoning (vLLM), with targeted unit coverage for the OpenAI DTOs.
Changes:
- Add Jackson
@JsonAlias("reasoning")to map vLLM’sreasoninginto existingreasoningContentfields. - Introduce unit tests validating OpenAI DTO deserialization for both full and streaming responses using
reasoning.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/formatter/openai/dto/OpenAIMessage.java | Accept reasoning as an alias for reasoning_content during deserialization. |
| agentscope-core/src/main/java/io/agentscope/core/formatter/dashscope/dto/DashScopeMessage.java | Accept reasoning as an alias for reasoning_content during deserialization. |
| agentscope-core/src/test/java/io/agentscope/core/formatter/openai/dto/OpenAIMessageReasoningFieldTest.java | Add tests covering reasoning_content vs reasoning for OpenAI message/response (including streaming delta/chunk). |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
liangxingguang
pushed a commit
to liangxingguang/agentscope-java
that referenced
this pull request
May 21, 2026
…for deserialization (agentscope-ai#1086)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.10
Description
This PR only handles the reading logic to quickly support Qwen 3.5 models on the latest vLLM version. The implementation for writing back thinking blocks will be addressed in a follow-up PR.
Fix #848
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)