Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(deps): bump elasticsearch-java from 8.12.0 to 9.3.0#713

Merged
AlbumenJ merged 2 commits into
agentscope-ai:mainfrom
guanxuc:es-9
Feb 5, 2026
Merged

chore(deps): bump elasticsearch-java from 8.12.0 to 9.3.0#713
AlbumenJ merged 2 commits into
agentscope-ai:mainfrom
guanxuc:es-9

Conversation

@guanxuc
Copy link
Copy Markdown
Contributor

@guanxuc guanxuc commented Feb 4, 2026 •
edited
Loading

AgentScope-Java Version

1.0.9

Description

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team February 4, 2026 05:43
@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist Bot commented Feb 4, 2026

Summary of Changes

Hello @guanxuc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant upgrade of the elasticsearch-java client library to version 9.3.0. This update required a comprehensive refactoring of the Elasticsearch integration, including transitioning to the Rest5Client and Rest5ClientTransport components, and adapting the underlying Apache HTTP client configurations for SSL and authentication. The primary goal is to ensure compatibility with the latest Elasticsearch client, potentially benefiting from improved performance, security, and new features.

Highlights

  • Dependency Update: The elasticsearch-java client library has been updated from version 8.12.0 to 9.3.0 across the project's pom.xml files.
  • Elasticsearch Client Migration: The Elasticsearch client implementation has been migrated from the older RestClient and RestClientTransport to the newer Rest5Client and Rest5ClientTransport classes, aligning with the updated library version.
  • Apache HTTP Client Upgrade: Underlying Apache HTTP client dependencies and related SSL/authentication configurations have been updated to their client5 equivalents, including changes to HttpHost, AuthScope, BasicCredentialsProvider, and SSL context handling.
  • Dense Vector Similarity: The DenseVectorProperty similarity setting has been adjusted to use the new DenseVectorSimilarity.Cosine enum instead of a string literal.
Changelog
  • agentscope-dependencies-bom/pom.xml
    • Bumped elasticsearch.version from 8.12.0 to 9.3.0.
    • Removed an extraneous empty line.
  • agentscope-examples/advanced/pom.xml
    • Updated elasticsearch-java dependency version from 8.12.0 to 9.3.0.
  • agentscope-extensions/agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/ElasticsearchStore.java
    • Updated imports for Elasticsearch client and Apache HTTP client classes to reflect the new versions.
    • Replaced RestClient with Rest5Client and RestClientTransport with Rest5ClientTransport.
    • Modified authentication setup to use AuthScope(null, -1) and password.toCharArray() for credentials.
    • Refactored SSL verification configuration within the HTTP client builder to utilize DefaultClientTlsStrategy.
    • Changed DenseVectorProperty similarity from a string literal "cosine" to the DenseVectorSimilarity.Cosine enum.
Activity
  • The pull request was created by guanxuc.
  • The author has completed all items in the checklist, indicating that the code has been formatted, tests are passing, Javadoc comments are complete, and related documentation has been updated.
  • The PR description mentions a related issue: #710.
  • No explicit review comments or further activity are provided in the context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates the Elasticsearch Java client from version 8.12.0 to 9.3.0 across the project. The changes correctly reflect the API modifications in the new client version, including updated imports, changes in RestClient to Rest5Client, and adjustments to SSL configuration and dense vector similarity settings. The use of toCharArray() for passwords is a good security practice. Overall, the upgrade appears to be handled well.

Comment thread agentscope-examples/advanced/pom.xml
Comment thread ...ope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/ElasticsearchStore.java
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../agentscope/core/rag/store/ElasticsearchStore.java 85.71% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@AlbumenJ AlbumenJ merged commit 467df7b into agentscope-ai:main Feb 5, 2026
6 checks passed
@guanxuc guanxuc deleted the es-9 branch February 5, 2026 09:02
@RainYuY
Copy link
Copy Markdown
Contributor

RainYuY commented Apr 7, 2026

Does this upgrade seem to have caused compatibility issues with ES8?

Caused by: co.elastic.clients.transport.TransportException: node: http://localhost:9200/, status: 400, [es/indices.exists] Expecting a response body, but none was sent
at co.elastic.clients.transport.ElasticsearchTransportBase.getApiResponse(ElasticsearchTransportBase.java:359) ~[elasticsearch-java-9.3.0.jar:na]
at co.elastic.clients.transport.ElasticsearchTransportBase.performRequest(ElasticsearchTransportBase.java:156) ~[elasticsearch-java-9.3.0.jar:na]
at co.elastic.clients.elasticsearch.indices.ElasticsearchIndicesClient.exists(ElasticsearchIndicesClient.java:1266) ~[elasticsearch-java-9.3.0.jar:na]
at io.agentscope.core.rag.store.ElasticsearchStore.ensureIndex(ElasticsearchStore.java:332) ~[agentscope-dewu-1.0.11.jar:na]
... 87 common frames omitted

iridescentpeo pushed a commit to feelshana/agentscope-java that referenced this pull request Apr 21, 2026
@guanxuc
chore(deps): bump elasticsearch-java from 8.12.0 to 9.3.0 (agentscope…
536f626 
…-ai#713)

## AgentScope-Java Version

1.0.9

## Description

* chore(deps): bump elasticsearch-java from 8.12.0 to 9.3.0
* Closes: agentscope-ai#710 

## Checklist

Please check the following items before code is ready to be reviewed.

- [x]  Code has been formatted with `mvn spotless:apply`
- [x]  All tests are passing (`mvn test`)
- [x]  Javadoc comments are complete and follow project conventions
- [x] Related documentation has been updated (e.g. links, examples,
etc.)
- [x]  Code is ready for review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guanxuc @RainYuY @AlbumenJ